search

lburgazzoli / gradle-karaf-features-plugin

Apache License 2.0
4 stars 13 forks source link

Added osgi detection and output to file to KarafFeaturesGenTask #1

Closed mbelling closed 10 years ago

mbelling commented 10 years ago

I had written a plugin for Karaf features generation, but I liked your overall solution better. In a fork added OSGi detection for dependencies, so you are not forced to manually list all wrappings. I also changed the output to a file. Feel free to use the code, change it, or ignore it completely. This is my first time contributing directly to a Github project, and first time with a pull request, so my apologies if I messed anything up.

lburgazzoli commented 10 years ago

Hi Matt, thank you very much for the contribution. What you did was in my pipeline since the beginning but you know, time is unfortunately limited.

Only one question: can you please add the possibility to configure the output of the task? I mean, the name and the location of the file and the possibility to write the feature to stdout (this is for testing)?

mbelling commented 10 years ago

Hello, If I get some extra time I'll see what I can do. It shouldn't be too hard to do. I am pretty new at creating Gradle plugins, so I will have to do some looking around to find the proper way of configuring them.

lburgazzoli commented 10 years ago

I've added a partial solution for the output directory in the meanwhile. Do not hesitate to do something better :-)