lburgazzoli / gradle-karaf-features-plugin

Apache License 2.0
4 stars 13 forks source link

Exclude transitive dependencies support added #12

Closed SOVALINUX closed 8 years ago

SOVALINUX commented 8 years ago

It fixes issue #11 Actually it my first code in Groovy, so sorry in advance for silly mistakes

Backward compatibility saved for feature descriptor

Some debug information added (it really helped me understood what's going on)

Readme updated with some examples

SOVALINUX commented 8 years ago

Luca, could you please orient me when you can find some time to review this request? I'm just thinking about to release it to our corporate network or wait for the main stream

lburgazzoli commented 8 years ago

Hope to have a look by tomorrow, sorry for the delay.

lburgazzoli commented 8 years ago

I do not like this syntax as it is misleading :

   project(project(':subproject1'))
    project {
        project = project('subproject2')
        excludeTransitiveDependencies = true //false by default
   }

I would like something like:

   project(':subproject1') {
       dependencies {
           transitive = false
       }
   }

This should be a shortcut to avoid writing your own custom configuration with transitive dependencies excluded.

Can you implement it ?

SOVALINUX commented 8 years ago

Okay, I'll try to implement it And question about backward compatibility currently the only working way is to write

project(project(':subproject1'))

It because method project takes one argument of type Project

Should I break this approach?

lburgazzoli commented 8 years ago

Yes break it, I will highlight it in the documentation :-)

SOVALINUX commented 8 years ago

I've updated DSL, it even backward compatible

lburgazzoli commented 8 years ago

Can you add your name to the @author tag on the files you have worked on? :-)

lburgazzoli commented 8 years ago

Thank you for the PR.

I've released as 2.7.0, it so it should be available soon in Maven Central