lburgazzoli / gradle-karaf-features-plugin

Apache License 2.0
4 stars 13 forks source link

Option (remap) to specify packaging #22

Closed vhusainov closed 8 years ago

vhusainov commented 8 years ago

Please, add an option to specify packaging. I've got a feature which contains war.

For now, I'm using following workaround:

bundle("artifact") {
  remap.version = "$remap.version/war"
}
lburgazzoli commented 8 years ago

How do you add WARs ? I mean something like

        compile "org.apache.activemq:activemq-web-console:5.12.1@war"
vhusainov commented 8 years ago

I forgot to tell that in my case this is a project dependency, that's why I'm using remap...

lburgazzoli commented 8 years ago

Can you please check if the latest 2.9.7-SNAPSHOT does what you need ?

bundle("group:name") {
    type = 'war'
}

If the bundle is already a war, it should not be required

lburgazzoli commented 8 years ago

@vhusainov have you had any time to test it ?

vhusainov commented 8 years ago

Sorry for delay. Now it works fine, but plugin could detect packaging automatically (for project dependencies). That is how I do it in my code:

if (dep.dependencyProject.plugins.hasPlugin(WarPlugin)) {
  type = 'war';
}
lburgazzoli commented 8 years ago

This is for artifacts generated by the project but not for dependencies, I need to improve this area

lburgazzoli commented 8 years ago

Can you please close this if fixed by PR #25 ?