Rename karaf-features-gen to gradle-karaf-plugin

lburgazzoli commented 9 years ago

@sebersole any problem if I rename the plugin to gradle-karaf-plugin

sebersole commented 9 years ago

It is generally considered bad for to have gradle in the name of a gradle plugin On May 19, 2015 3:21 AM, "Luca Burgazzoli" notifications@github.com wrote:

@sebersole https://github.com/sebersole any problem if I rename the plugin to gradle-karaf-plugin

— Reply to this email directly or view it on GitHub https://github.com/lburgazzoli/lb-gradle-plugins/issues/9.

lburgazzoli commented 9 years ago

I meat to have gradle-karaf-plugin as artifact-id and project name

sebersole commented 9 years ago

I'll turn that question back around on you.. :) If you saw a project named gradle-karaf-plugin what would you think it did? To me that name implies somehow running Karaf from Gradle.

lburgazzoli commented 9 years ago

You are right but that is not different from the official karaf-maven-plugin.

Then if I want to add also kar and custom karaf distribution tasks, would you get it from karaf-feature-gen ? :-)

If you know a better name please share :-)

sebersole commented 9 years ago

Maven essentially requires plugins to have maven in their name (or at least used to) because its how they automatically recognize plugin short naming. And it is an awful idea to base naming conventions on Maven :)

I barely know what a KAR file is. After you mentioned it I read and determined that it is a Karaf features repository (just like the XML) that also bundles the bundle jars). So personally, knowing what a KAR and understanding Karaf feature repositories I would absolutely get that from the name karaf-features-gen.

I have no idea what a "Karaf distribution" is. But I think you need to be careful about bundling so much unrelated stuff in one plugin. Generating a feature repo XML and a feature repo archive are obviously completely related concepts. I guess it depends what this "Karaf distribution" concept is.

On Tue, May 19, 2015 at 10:10 AM, Luca Burgazzoli notifications@github.com wrote:

You are right but that is not different from the official karaf-maven-plugin.

Then if I want to add also kar and custom karaf distribution tasks, would you get it from karaf-feature-gen ? :-)

If you know a better name please share :-)

— Reply to this email directly or view it on GitHub https://github.com/lburgazzoli/lb-gradle-plugins/issues/9#issuecomment-103540941 .

lburgazzoli commented 9 years ago

would karaf-features-plugin sound better? I do not like the '-gen' :-)

lburgazzoli commented 9 years ago

At the end I've renamed the whole project, btw I found that hibernate uses "gradle-" in artifact id :-)

sebersole commented 9 years ago

Way to be selective to back up your argument :) I have created many many many plugins. Yes my initial one used gradle in the name. I do this thing called learning from my mistakes :)

On Tue, May 19, 2015 at 12:39 PM, Luca Burgazzoli notifications@github.com wrote:

At the end I've renamed the whole project, btw I found that hibernate uses "gradle-" in artifact id :-)

— Reply to this email directly or view it on GitHub https://github.com/lburgazzoli/gradle-karaf-features-plugin/issues/9#issuecomment-103610520 .

lburgazzoli commented 9 years ago

I'd love a better naming but at the moment is the one that fits the conventions we are using so I did it :-) a little rude I know

sebersole commented 9 years ago

no worries. if I ever get fed up I'll just fork it :)

On Tue, May 19, 2015 at 3:00 PM, Luca Burgazzoli notifications@github.com wrote:

I'd love a better naming but at the moment is the one that fits the conventions we are using so I did it :-) a little rude I know

— Reply to this email directly or view it on GitHub https://github.com/lburgazzoli/gradle-karaf-features-plugin/issues/9#issuecomment-103651558 .

lburgazzoli commented 9 years ago

Hope not :-) Hope to see some more contributions in the future

lburgazzoli / gradle-karaf-features-plugin

Rename karaf-features-gen to gradle-karaf-plugin #9