search

lc-3-2 / lc32sim

LC-3.2 simulator
0 stars 0 forks source link

Fix behavior of RSHFA to match specification #15

Closed ammrat13 closed 1 year ago

ammrat13 commented 1 year ago

Previously, RSHFA was using the least significant three bits as the immediate, with zero being treated as eight. Now, it treats the least significant five bits as the immediate as-is. This is how the compiler generates RSHFA.

Before merging, we should:

ammrat13 commented 1 year ago

This is not what we agreed on for shifts. Still, I suggest merging this PR since it's a good baseline to have. In other words, we've confirmed that the compiler works with this simulator.

sameer-s commented 1 year ago

Agreed, merging it in for now and then we will update both the compiler and simulator soon to conform to the new spec.