lc-soft / LCUI

C library for building user interfaces
https://lcui-dev.github.io
MIT License
4.13k stars 356 forks source link

test(output): update tests to use libtest.h (fix #197) #208

Closed jduo closed 4 years ago

jduo commented 4 years ago

Change tests to use libtest.h as specified in Issue #197.

Fixes #197 .

Changes proposed in this pull request:

@lc-soft


IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#197: Update test program](https://issuehunt.io/repos/5293802/issues/197) ---
commit-lint[bot] commented 4 years ago

Tests

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
lc-soft commented 4 years ago

Note that TEST_LOG is still used in a few places where we log purely informational messages that don’t match functions in libtest.h

For code that uses TEST_LOG like below, you can replace TEST_LOG with Logger_Debug.

https://github.com/lc-soft/LCUI/blob/4e6e459cd21f5281d13848a0cc80189e1c145618/test/test_thread.c#L19-L38

jduo commented 4 years ago

Note that TEST_LOG is still used in a few places where we log purely informational messages that don’t match functions in libtest.h

For code that uses TEST_LOG like below, you can replace TEST_LOG with Logger_Debug.

https://github.com/lc-soft/LCUI/blob/4e6e459cd21f5281d13848a0cc80189e1c145618/test/test_thread.c#L19-L38

I've replaced calls to TEST_LOG with Logger_Debug. I've also deleted the now unused macros in test.h

jduo commented 4 years ago

The output text style should be consistent, I suggest you change them to lower case.

- Check *****
+ check *****

image Done.