search

lcatlett / blt-drush-alias

Acquia BLT plugin to generate Acquia drush aliases
10 stars 8 forks source link

Namespace for AcquiaCloudApi Connector and Client needs updating #6

Open wu-edward opened 4 years ago

wu-edward commented 4 years ago

Got this error on the 2.0 release: PHP Fatal error: Uncaught Error: Class 'AcquiaCloudApi\CloudApi\Connector' not found in /vendor/lcatlett/blt-drush-alias/src/Blt/Plugin/Commands/DrushAliasCommand.php:193

Looks like the namespaces in typhonius/acquia-php-sdk-v2 were changed in this commit: https://github.com/typhonius/acquia-php-sdk-v2/commit/2d6b412ee936b07e73eee9d0486f8a0f8db4daac

So at the very least, probably AcquiaCloudApi\CloudApi\Connector needs to be AcquiaCloudApi\Connector\Connector and AcquiaCloudApi\CloudApi\Client needs to be AcquiaCloudApi\Connector\Client. I haven't yet investigated further whether the class method calls need updating as well.

siliconmeadow commented 4 years ago

As well as changes to the namespaces, there were changes to numbers of arguments required in arguments, etc. I wonder if it might be better to specify a specific version of the typhonius/acquia-php-sdk-v2 in the composer.json file, instead?