search

lcdsantos / jQuery-Selectric

jQuery plugin for easy manipulation and customization of HTML selects
http://selectric.js.org/
MIT License
727 stars 157 forks source link

Suggestion: Rename label and button classes #174

Open nathanhornby opened 7 years ago

nathanhornby commented 7 years ago

I'm having trouble with generically named classes interfering with my own, namely .label and .button.

I'd suggest renaming to .selectric-label and .selectric-button to avoid as many compatibility issues as possible.

gearsdigital commented 7 years ago

There is an option which allows you to define a custom class prefix.

/*
     * Type: Object
     * Description: Customize classes.
     */
    customClass: {
      prefix: 'selectric', // Type: String.  Description: Prefixed string of every class name.
      camelCase: false     // Type: Boolean. Description: Switch classes style between camelCase or dash-case.
    },
nathanhornby commented 7 years ago

Excellent that's good to know!

I still think the current classes are begging for conflicts though.

gearsdigital commented 7 years ago

Indeed! That's a thing which should be fixed soon. Namespacing is always a good idea. Would you like to provide a PR?

nathanhornby commented 7 years ago

It's certainly simple enough for me to tackle! Time is my enemy at the moment but feel free to assign.

On Wed, 10 May 2017, 21:32 Steffen Giers, notifications@github.com wrote:

Indeed! That's a thing which should be fixed. Namespacing is always a good idea. Would you like to provide a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lcdsantos/jQuery-Selectric/issues/174#issuecomment-300603843, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4jgM7M5mmPFQIj_WZtLjzEa6gW_Dq-ks5r4h7agaJpZM4MqCcZ .

gearsdigital commented 7 years ago

Awesome! Don't feel stressed, take the time you need :)

Feel free to ask if you have any questions!