fixes for one memory corruption, recursive include, external warning

lcfiplus / LCFIPlus

Flavor tagging code for ILC detectors

https://confluence.slac.stanford.edu/display/ilc/LCFIPlus

GNU General Public License v3.0

6 stars 19 forks source link

fixes for one memory corruption, recursive include, external warning #20

Closed andresailer closed 7 years ago

jstrube commented 7 years ago

Nice catch on the memory corruption. Thanks for submitting this.

jstrube commented 7 years ago

Not sure why this fails. Does this depend on Marko's travis update? I've only merged that just now.

petricm commented 7 years ago

The old configuration of the CI does not fork for quite some time, I have made the PR for the update of the CI nearly 6 months ago.

jstrube commented 7 years ago

Yes. Which I've just merged, as I said in my comment. It looks like there's no reason why this would fail tests, so please change NULL to nullptr, and I can merge this.

petricm commented 7 years ago

This fails the test because it's an outdated CI, this PR is before you merged the CI update.

andresailer commented 7 years ago

rebased and using nullptr. Tests have passed.

jstrube commented 7 years ago

Thank you.