Closed andresailer closed 7 years ago
All tests pass and I have tested locally that this takes care of #19. Pinging @suehara for a final confirmation, but looks good to me.
Thank you for taking this on.
Updated implementation, first comment.
Looks good to merge. @tomohikosan @suehara @MasakazuKurata any comments? If not, I'd like to merge before the end of the week.
@jstrube @tomohikosan @suehara @MasakazuKurata Can this be merged now? Thanks 👍
@andresailer is this urgent? I haven't heard from another dev and the week isn't over, yet.
It is over for me...
I think this fixes #19
Edit: minimal changes now, only the map must not be copied, because the assignment operator calls
clear
, which otherwise deletes the objects from the shallow copy, not a problem if the map is empty.