search

lcfiplus / LCFIPlus

Flavor tagging code for ILC detectors
https://confluence.slac.stanford.edu/display/ilc/LCFIPlus
GNU General Public License v3.0
6 stars 19 forks source link

Fix parameter copy ctor #21

Closed andresailer closed 7 years ago

andresailer commented 7 years ago

I think this fixes #19

Edit: minimal changes now, only the map must not be copied, because the assignment operator calls clear, which otherwise deletes the objects from the shallow copy, not a problem if the map is empty.



~~~I didn't implement the copy for arbitrary classes, because it wasn't used in the configuration I was testing with. Is this needed?~~~

Also fixed something in the `remove` and `clear` function were two times the double cases existed but never the float

BEGINRELEASENOTES
- lcfiplus::Parameters: fix implementation of the copy constructor, fixes lcfiplus/LCFIPlus#19 

ENDRELEASENOTES
jstrube commented 7 years ago

All tests pass and I have tested locally that this takes care of #19. Pinging @suehara for a final confirmation, but looks good to me.

Thank you for taking this on.

andresailer commented 7 years ago

Updated implementation, first comment.

jstrube commented 7 years ago

Looks good to merge. @tomohikosan @suehara @MasakazuKurata any comments? If not, I'd like to merge before the end of the week.

andresailer commented 7 years ago

@jstrube @tomohikosan @suehara @MasakazuKurata Can this be merged now? Thanks 👍

jstrube commented 7 years ago

@andresailer is this urgent? I haven't heard from another dev and the week isn't over, yet.

andresailer commented 7 years ago

It is over for me...