lcfiplus / LCFIPlus

Flavor tagging code for ILC detectors
https://confluence.slac.stanford.edu/display/ilc/LCFIPlus
GNU General Public License v3.0
6 stars 19 forks source link

Add dummy vertex to avoid accessing null ptr if no primary vertex found. #60

Closed ryonamin closed 2 years ago

ryonamin commented 2 years ago

BEGINRELEASENOTES

ryonamin commented 2 years ago

@tmadlener @gaede Thank you for pointing the problem out and suggesting solutions! My code worked unfortunately in my test and I missed the potential but crucial problem. Regarding the point Thomas suggested: "when the internal primaryVertices collection is filled from the LCIO contents", this idea sounds good to me but on the other hand, this fix leads us to reprocess the existing samples and this is a bit annoying, I guess. So I took Frank's solution and make a new pull request #61