search

lcfiplus / LCFIPlus

Flavor tagging code for ILC detectors
https://confluence.slac.stanford.edu/display/ilc/LCFIPlus
GNU General Public License v3.0
6 stars 19 forks source link

Unnecesary loop over empty std::vector inside VertexFinderSuehara #65

Open dudarboh opened 1 year ago

dudarboh commented 1 year ago

Dear experts,

The size of the savetrk is always 0. So we never actually enter the following loop, which is 44 lines long:

https://github.com/lcfiplus/LCFIPlus/blob/8a4629883c1e1b8baef1feb2b6871859ecdda735/src/VertexFinderSuehara.cc#L554-L598

Is this expected behaviour?

I am not sure what was the purpose of this loop, but at this stage of the vertexing this loop looks redundant. Wouldn't it better to remove it?

cheers, Bohdan

suehara commented 1 year ago

Thanks. That's funny. I checked the history and found it's not from the original code for dbd. I think it is not harmful...maybe OK to remove it.