search

lcfiplus / LCFIPlus

Flavor tagging code for ILC detectors
https://confluence.slac.stanford.edu/display/ilc/LCFIPlus
GNU General Public License v3.0
6 stars 19 forks source link

Some ParticleID objects are not always filled #69

Open tmadlener opened 5 months ago

tmadlener commented 5 months ago

For example the RefinedVertex PID object is only conditionally filled. From having had a quick look at the code this seems to mainly be done for some internal caching(?).

I am mainly opening this issue since I have stumbled over this while updating the LCIO <-> EDM4hep conversion for accommodating https://github.com/key4hep/EDM4hep/pull/268 . I am not sure if there is an easy fix, but I would at least like to have some paper trail to document the reason for some implementations that might need to work around this fact.

Zehvogel commented 1 month ago

This is also an issue for the jet clustering. In particular when there is an event where no jet is found no PID object is created.