search

lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.
MIT License
410 stars 35 forks source link

make methods protected #117

Closed bendavies closed 6 years ago

bendavies commented 6 years ago
Q A
Bug fix? yes
New feature? yes
BC breaks? no
Related tickets
License MIT

Any reason these are private? My API returns application/hal+json, so I wanted to override assertJsonHeader.

lchrusciel commented 6 years ago

Can you do the same for XML test case?

Zales0123 commented 6 years ago

ping @bendavies, doing the same for XmlApiTestCase would be nice :)

bendavies commented 6 years ago

done!

lchrusciel commented 6 years ago

Thanks Ben! 🏎