search

lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.
MIT License
410 stars 35 forks source link

make PolishSymfonyCommunity/SymfonyMockerContainer optional #141

Closed videni closed 5 years ago

videni commented 5 years ago

hi, can you make PolishSymfonyCommunity/SymfonyMockerContainer optional, seems it is not actively maintained, also it doesn't support Symfony4. it will caused a weird exception when it is used with Symfony 4.2.2, see stopwatch error after updating symfony to v4.2.2 . please consider make is optional.

I send a PR

pamil commented 5 years ago

We fixed the stopwatch error by removing cleanupContainer method from kernels derived from Sylius (it was used to boost performance, but it has no impact now).

videni commented 5 years ago

@pamil, thanks, I see, it take lots of time to figure out why that error happened, do you notice the MockerContainer from PolishSymfonyCommunity/SymfonyMockerContainer repo can not mock private service in Symfony4 anymore ? I created an issuecan't mock private service in symfony4 there, but no one answered.