lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.

MIT License

410 stars 35 forks source link

Add support for PHPUnit 8 #145

Closed emodric closed 5 years ago

emodric commented 5 years ago

Opening against 3.1.4 branch, hoping for 3.1.5 :)

Still needs a fix in Symfony kernel for their tearDown and setUp methods, but since this should be backwards compatible, no need to wait for merge.

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Related tickets	None
License	MIT

lchrusciel commented 5 years ago

I would love to merge this but the build is red :(

emodric commented 5 years ago

Hm, okay. I guess we will have to wait for Symfony fix.

pamil commented 5 years ago

Symfony won't fix until 5.x as it would require a BC break 😢

emodric commented 5 years ago

@pamil Any source?

pamil commented 5 years ago

@emodric https://symfony.com/doc/current/contributing/code/bc.html#using-our-classes - adding a return typehint would break all the existing tests. I've sent #146 with an alternative solution (we could add support in v4.0).

lchrusciel commented 5 years ago

146 merged. Will the bump to 4 do the job for you? I prefer to drop version 3 support. On the other hand, if you need it, feel free to backport changes.

emodric commented 5 years ago

Bump to v4 is fine :+1:

emodric commented 5 years ago

@lchrusciel BTW, it looks like updating packagist.org does not work, you might wanna check it out :)

lchrusciel commented 5 years ago

I still didn't publish it. I just noticed that I need to merge #147 + #143. On it :)

emodric commented 5 years ago

Wasn't talking about the tag. Master branch is also not updated, so it's pulling an old revision.

lchrusciel commented 5 years ago

Thanks Edi a lot! My fault. Anyway, it is already updated manually.

lchrusciel commented 5 years ago

Now it should be better