search

lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.
MIT License
410 stars 35 forks source link

Added UUID matcher #149

Closed MichaelKubovic closed 5 years ago

MichaelKubovic commented 5 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets
License MIT

Is there any reason why MatcherFactory doesn't extend from https://github.com/coduo/php-matcher/blob/master/src/Factory/SimpleFactory.php? It would prevent this sort of issues in the future.

lchrusciel commented 5 years ago

Hey Michael! Thanks for your contribution. Of course no, we should add it. Can you add some test for that? Just extend one of the models and some hardcoded UUID.

MichaelKubovic commented 5 years ago

I've added uuid to Product model and also refactored MatcherFactory to rely on SimpleFactory.

lchrusciel commented 5 years ago

Thank you, Michael! :tada: