search

lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.
MIT License
410 stars 35 forks source link

Make ApiTestCase::tearDown protected #152

Closed emodric closed 5 years ago

emodric commented 5 years ago
Q A
Bug fix? yes?
New feature? no
BC breaks? no
Related tickets N/A
License MIT

PHPUnit TestCase::tearDown is protected itself, so makes sense for this one to be too.

lchrusciel commented 5 years ago

Thank you, Edi! :1st_place_medal:

emodric commented 5 years ago

Thanks you :)

If possible, can you tag 4.0.2 ?

lchrusciel commented 5 years ago

I have some problem with this release, as this PR, together with #149 are kind of BC-Breaks... I have to define some BC policy so that it will be clear. I'm wondering if 4.1 could be suitable as well

emodric commented 5 years ago

Well, this PR should not be a BC break, since classes extending this one can widen the scope of an overriden method (protected -> public), so you could actually cherry-pick this to 4.0.

emodric commented 5 years ago

Hi @lchrusciel ! Any news on 4.1 release? I'm trying to use @uuid@ matcher, but 4.0 doesn't allow it, since we need #149 . Thanks!

lchrusciel commented 5 years ago

I just published it. Sorry for decision lag :D

emodric commented 5 years ago

Yaay, thanks! :)