Add support for PHP 8.0

lchrusciel / ApiTestCase

Handy PHPUnit test case for testing JSON APIs in your Symfony applications.

MIT License

410 stars 35 forks source link

Add support for PHP 8.0 #179

Closed emodric closed 3 years ago

emodric commented 3 years ago

I went ahead and added support for PHP 8.0 myself, to make it easier for you, @lchrusciel :)

I have designated this in the changelog as 5.1 as there's no need for major version bump.

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Related tickets	fixes #178
License	MIT

pamil commented 3 years ago

Looks like Travis CI build takes a day to run and then fails because of a BC break in ECS - @emodric could you temporarily disable that check by adding || true at the end of the script in composer.json? GitHub Actions would help as well as I've mentioned in #180, since it takes a while to get feedback now.

emodric commented 3 years ago

@pamil I've pushed the || true "fix" :+1:

emodric commented 3 years ago

@pamil Any status with this? It seems the fix did not help with Easy Coding Standard :/

But the tests do pass, except for PHP 7.2, where I really do not know why. We can just remove support for PHP 7.2 though :D

lchrusciel commented 3 years ago

Will be part of #182. Edi thanks a lot for the work bootstrap!