search

lckjosh / pe

0 stars 0 forks source link

Capitalisation bypasses the restriction on one animal per day #10

Open lckjosh opened 11 months ago

lckjosh commented 11 months ago

image.png

Steps to reproduce: Add an animal once Then add the same animal again but change the capitalisation of the name The animal will be added

Expected: The animal should not be added due to the constraint. Perhaps removing the constraint would be better

soc-se-bot commented 11 months ago

Team's Response

Indeed, to make the application more foolproof we could have made things non-case sensitive!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unhomogene case sensitivity

image.png

In the add command, the two species are considered differents (otherwise i could'nt have edited the second to create a duplicate) but in the summary, the species are considered equivalent.

[original: nus-cs2113-AY2324S1/pe-interim#970] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response.
Will take note of this, and make the necessary improvements in the future.

We have marked this as a duplicate of issue #920 as this is an issue not with the summary command, but rather the add command's case sensitivity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]