search

lckjosh / pe

0 stars 0 forks source link

Inconsistency in input sanitisation for add command #12

Open lckjosh opened 11 months ago

lckjosh commented 11 months ago

image.png

Steps to reproduce: Enter 'add D/13-02-2000 S/testing N/asd R/ R/j' The command is successful

Enter 'add D/13-02-2000 S/testing N/asN/ R/jj' The command shows an error

Expected: The first command should fail as well as it contains '/R' in the remarks

soc-se-bot commented 11 months ago

Team's Response

This is expected behaviour. As the remarks field is optional and users are likely to include special characters in the remarks section to add additional details, we have also allowed for the use of / in the remarks field.

However, we agree that we could extend our product to allow for the / character in other fields, as we have acknowledged in issue #398.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Perhaps this should be marked as not in scope intead of rejected, as you say that you could extend the product to allow for the ' character in other fields.