search

lckjosh / pe

0 stars 0 forks source link

Very long inputs not handled #3

Open lckjosh opened 11 months ago

lckjosh commented 11 months ago

image.png

Steps to reproduce: Enter 'add D/03-12-2003 S/this is a very long species name i wonder how the program will handle it will it throw an error or just accept it? N/asdf'

The output in list becomes messy Perhaps it would be good to impose a character limit on input

nus-se-bot commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

List command output is messy

image.png

Steps to reproduce: Edit the data file to contain this: 13-02-2001 / this is a very long species name i wonder how the program will handle it will it throw an error or just accept it? / asdf / 03-12-2003 / asdfjklasjdfkl / asdf / asdjklfkjlaskdfkl 03-12-2003 / asdfklja / asdjkfljkasldjfk / asdjklfkjasdfkl 03-12-2003 / ajskldfjklasjdfjasdkljfkldasj / xyz / asdjklfjaksdjfkasjkdfl 03-12-2003 / asdf / asdf / asdf 03-12-2003 / 1923123asdf / 123 / 1232141312312321 03-12-2003 / 123212312312321321321312 / 12312312 / 123213212321

Launch application and enter 'list'

The output is messay and not aligned due to the different lengths of the entries. The user may be confused and not know where to look, making it harder to use the application especially with more entries.

Adding some padding space to make everything aligned would be nice.

[original: nus-cs2113-AY2324S1/pe-interim#838] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

After checking, the longest species name in existent currently is Parastratiosphecomyia sphecomyioides, which is actually much shorter than the species name tested.
Hence we feel that this would not cause a huge issue for users. But the feedback will be taken into consideration to make our output neater and aligned for ease of reading.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The other issue has to do with user output formatting. This has more to do with input validation.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Since you mentioned that the longest species name in existent currently is Parastratiosphecomyia sphecomyioides, all the more I feel there should be a character limit on input, especially since it is not very hard to implement.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]