search

lckjosh / pe

0 stars 0 forks source link

Capital letters for add command parameters could be optimised to allow for lowercase #4

Open lckjosh opened 10 months ago

lckjosh commented 10 months ago

Currently the application only supports uppercase to specify parameters of the add command. Since it is a CLI application, perhaps allowing lowercase characters which are easier to type might be better.

nus-se-bot commented 10 months ago

Team's Response

Thank you for your response.
Will take note of this, and make the necessary improvements in the future.

However, since lower case i/ is used for add i/ and upper case I/ is used for index in edit I/
We did not make the characters case-insensitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: According to the module website, this should be considered a feature flaw:

image.png

Perhaps a different character could be used for the index in edit or the interactive in add.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I would consider this a medium severity as it is encountered in almost all commands that require input arguments, thus it is not a rare occurence.