lclevy / ADFlib

A free, portable and open implementation of the Amiga filesystem
GNU General Public License v2.0
84 stars 29 forks source link

Fixed / improved file support (ie. writing), other changes (new tests, cmd-line utilities, more strict interfaces, ...) #34

Closed t-w closed 1 year ago

t-w commented 1 year ago

There is plenty of changes in this PR. The main points are:

Please have a look and let know what you think.

There is still a lot of things to check/improve, eg:

but possibly it could be tagged as 0.8.0 (as 'reasonably working').

lclevy commented 1 year ago

Ok for me for this PR and 0.8.0

lclevy commented 1 year ago

I have no time to follow all proposed changes, sorry. I let @t-w decide when and what to merge

lclevy commented 1 year ago

👍

t-w commented 1 year ago

Thanks for all the checks and insights.

I am aware this is a big PR (bigger that it should be...), but doing this another way would require a year to do things in small chunks discussing every small change... Once the main things will be more-less established (eg. build system configs), it will be more feasible to work in smaller bunches, solving one problem at a time.

So, to conclude, let know if it is OK to merge it (or eg. if you prefer to check something more).

lclevy commented 1 year ago

Ok for merging. And for smaller commits next time 😉