Closed t-w closed 1 year ago
Ok for me for this PR and 0.8.0
I have no time to follow all proposed changes, sorry. I let @t-w decide when and what to merge
👍
Thanks for all the checks and insights.
I am aware this is a big PR (bigger that it should be...), but doing this another way would require a year to do things in small chunks discussing every small change... Once the main things will be more-less established (eg. build system configs), it will be more feasible to work in smaller bunches, solving one problem at a time.
So, to conclude, let know if it is OK to merge it (or eg. if you prefer to check something more).
Ok for merging. And for smaller commits next time 😉
There is plenty of changes in this PR. The main points are:
const
is setconst
adf_file
)adf
+ subsystem (eg.File
) + operation (eg.Write
)File
toadf_file
)struct File
->struct AdfFile
)examples/
)citest
branch (so that it is not overused with every push/merge - some tests are a bit I/O-expensive)Please have a look and let know what you think.
There is still a lot of things to check/improve, eg:
but possibly it could be tagged as
0.8.0
(as 'reasonably working').