lclevy / ADFlib

A free, portable and open implementation of the Amiga filesystem
GNU General Public License v2.0
90 stars 30 forks source link

adfFileOpen mode READWRITE changed to WRITE (and modes changed to bitmasks); versioning in .h #52

Closed t-w closed 1 year ago

t-w commented 1 year ago
  1. One more time, I had a look at adfFileOpen() and Amiga file permissions, and noticed the lack of possibility of opening a file in write-only mode, which, while may not be widely needed, can be required to properly use the Amiga file protection bits: there can be some (rare) cases where an Amiga file has the w protection bit unset (ie. the file can be written) and r bit set (cannot be read). So, without this change, opening a file properly using the Amiga file protection bits would not be possible.

  2. Building fuseadf with the updated ADFlib, I noticed that c02c703 removed versioning from header files (adf_defs.h). It is very useful if the client code can store the version of the library with which it is built - it can then be checked in case of any issues (build version vs. runtime version). So:

    • c02c703 for adf_defs.h is reverted (and not defining in build system conf.: 949481a)
    • the bump version script does not update the date, it is done by a separated script

(plus a few minor changes/corrections in info files)

lclevy commented 1 year ago

Thanks @t-w