Opening devices in the current dev branch

[DidierMalenfant]

The following code in. add_dev.c:

struct AdfDevice * adfDevOpen ( const char * const  name,
                                const AdfAccessMode mode )
{
    const struct AdfDeviceDriver * const driver = adfGetDeviceDriverByDevName ( name );
    if ( driver == NULL || driver->openDev == NULL )
        return NULL;
    return driver->openDev ( name, mode );
}

seems to use name as both name for the device name and the adf name.

Am I reading this correctly?

[t-w]

Not quite.

Read carefully how the driver is gotten: "...ByDevName" means "get driver according to the device name" (not the driver name). It basically tries to match the device driver with device name (with a fallback/default to the dump file driver).

Actually, while changing the devices code recently, I was not sure if this is needed. It could be left totally to client code to match device driver with the device. I decided to leave it this way to simplify most cases and to keep compatibility with earlier code.

Note also that now the drivers can be enabled/disabled - so, for instance, there can be only one enabled and every adfDevOpen will use that one. In fact, matching is used only for "native" devices - and the native dev. driver is disabled by default.

There is a new function (adfDevOpenWithDriver) where the driver can be explicitly specified (by its name), so it is up to you which way you prefer in your code.

[t-w]

In fact, it is me who apparently haven't read carefully your question ;-) Sorry about that.

Yes - you are reading it right. This is a string representing:

• a device, which can be
  • a native device, depending which OS you use: /dev/sth in unix-likes, something else starting from "|" on Windows (not sure, never used that...) or
  • some custom, eg. a user-developed device with a driver implementing isDevice(name) function for matching device strings/names
• a file

However, how it will be used depends on which drivers are enabled:

• if there will be an enabled device driver that will say it is its device (with isDevice(name)) then that driver will be used
• if no driver matched the device name - it will be treated as a file (if the "dump" driver is enabled, if not - NULL pointer exception...)

(Sorry, one more time, I just responded to quickly...)