search

lclevy / ADFlib

A free, portable and open implementation of the Amiga filesystem
GNU General Public License v2.0
84 stars 29 forks source link

0.9.0 #80

Closed t-w closed 3 months ago

t-w commented 3 months ago

@lclevy I am going to make a new version, as in the title.

For now, PLEASE DO NOT MERGE IT YET! I submitted the PR for a review, I have to update at least the dates, so we merge it when ready.

Please have a look at the changes, in particular, note the change of the license (added LGPL2.1, so the lib becomes dual license, as we discussed).

rofl0r commented 3 months ago

reviewing ~300 commits seems to be a herculean task. why not simply use master, and add a tag when everything's polished ?

lclevy commented 3 months ago

I have no time to review all. I trust you.

I just have one question, is big endian support still there ?

t-w commented 3 months ago

@rofl0r, IMHO, it is polished well enough, enough to be used and tested by others.

I am not asking for reviewing every commit, it is not about checking every detail. It is rather about looking at overall shape and changes seen from higher-level described in ChangeLog etc. Details if something particular is noticed.

In fact, as the current maintainer, I could just make the release without any PRs and discussions, but there are things that I want to clarify with Laurent. Also, I value his opinion as the creator of ADFlib, he has good insights. Hence this PR.

@lclevy, yes, big endian is there (I just renamed the source file, if I remember well). (Btw. I sent you an email, please have a look and let me know).

lclevy commented 3 months ago

Ok the release on my side