search

lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

[MacOS] lcm installed via homebrew causes: SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats #378

Closed mnadler closed 1 year ago

mnadler commented 1 year ago

When I installed lcm using "brew lcm" is got: "SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats" when using the python bindings for LCM.

This was fixed after I built from source and installed.

mnadler commented 1 year ago

Homebrew is pulling in the lcm version at "https://github.com/lcm-proj/lcm/releases/download/v1.4.0/lcm-1.4.0.zip"

This version doesn't pull in the recent changes that deal with python3.10+ compatibility. Thanks @cho-m btw!

I'm happy to submit a pr to Homebrew to update this to an lcm release that takes this change into account.

To do so I need a new release to point to. @ashuang @edwinolson thoughts on declaring the current master lcm-1.4.1?

kyonifer commented 1 year ago

We're planning to release a new version of LCM shortly, after we clean out some backlog (see roadmap). Would love for you to submit the homebrew package for it after that.

nosracd commented 1 year ago

To do so I need a new release to point to. @ashuang @edwinolson thoughts on declaring the current master lcm-1.4.1?

There is now a 1.5.0 release that includes the fix

nosracd commented 1 year ago

I'm happy to submit a pr to Homebrew to update this to an lcm release that takes this change into account.

@mnadler Assuming you're still willing to update the homebrew LCM package, would you be willing to post a link to the homebrew PR here? I'm curious about how that process works.