Closed ihilt closed 1 year ago
I cannot build with this change.
$ mkdir build && cd build && cmake ..
...
-- Detecting CXX compile features - done
-- NAME_MISMATCHED (missing: FOUND_VAR GLib2_glib_FOUND REQUIRED_VARS)
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
Could NOT find GLib2 (missing: glib)
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
cmake/FindGLib2.cmake:119 (find_package_handle_standard_args)
CMakeLists.txt:10 (find_package)
$ cmake --version
cmake version 3.16.3
$ hostnamectl
...
Operating System: Ubuntu 20.04.5 LTS
Kernel: Linux 5.14.0-1058-oem
@judfs Thanks for reporting this issue. I see that this PR has increased the minimum required cmake version from 3.1 to 3.17 and that the apt
packages for 20.04 only provide 3.16. I'd rather not require focal users to install cmake via pip without further discussion, so I've reverted this change for now via 0066e9928114d05c784ee2ad439805bdcbea7742.
It appears that all that is needed here is to pass
NAME_MISMATCHED
to avoid the following warning when runningcmake
. Took this path since the docs indicate this is the intended way to handle mismatched names for packages. They do note that this is usually a mistake but since LCM has been working this way for quite a while I tend to think this is an exception.