Closed nosracd closed 1 year ago
This PR:
-Werror
Warnings fixed:
format-overflow
GLib-CRITICAL **: 10:09:34.795: g_hash_table_destroy: assertion 'hash_table != NULL' failed
Wshift-op-parentheses
Wswitch
Wpointer-sign
Wtautological-constant-out-of-range-compare
Wdeprecated-declarations
Wformat
I started going down the path of trying to fix warnings from -Wall and -Wextra but stopped. These commits are not included in the PR, but I'd appreciate if you could take a look at them and determine if any are actually helpful:
-Wall
-Wextra
This PR:
-Werror
as a compiler argument for both C and C++Warnings fixed:
format-overflow
: 9c7a4a47d14dbce11e9fea01217c969c2539b9eaGLib-CRITICAL **: 10:09:34.795: g_hash_table_destroy: assertion 'hash_table != NULL' failed
warnings while running lcm-gen: af37954152982da00ef1892cfd75ce97a7b56ccbWshift-op-parentheses
: 1927a43dc167425bedfb2345c7897c5eb7e3e134Wswitch
: a4d7fac403c2cff17a07f1dabc2950b4e367a22cWpointer-sign
: e520e621feb3158721d079ae64ffb959d2e2325bWtautological-constant-out-of-range-compare
: 52073cf738f34a95e57e4592e302f23993d79234Wdeprecated-declarations
: 405c5c6500162be10a5b6056bcf0aab45149e7d5Wformat
: 42a5b611cd5d59ced9c76e935328da7ea4597915I started going down the path of trying to fix warnings from
-Wall
and-Wextra
but stopped. These commits are not included in the PR, but I'd appreciate if you could take a look at them and determine if any are actually helpful: