search

lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

Remove doc-java from top-level docs CMakeLists.txt #424

Closed ihilt closed 1 year ago

ihilt commented 1 year ago

Allow lcm-java/CMakeLists.txt to have control over adding doc-java to the doc target since it is created there.

This resolves the following error:

CMake Error at docs/CMakeLists.txt:59 (add_dependencies):
The dependency target "doc-java" of target "doc" does not exist.

Observed on Fedora 37.

nosracd commented 1 year ago

For posterity, while this change is unambiguously better than before there is still a very small risk:

if someone has Java installed and build the docs the Java API will be missing and there will probably be broken links.

This LGTM though.