lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

Update changelog #426

Closed nosracd closed 1 year ago

nosracd commented 1 year ago

Marked as draft until the date can be filled in. Suggestions from all are welcome.

nosracd commented 1 year ago

@tprk77 We're wrapping up on preparation for the 1.5.0 release. Is there anything (lua-related or otherwise) that you'd like to make it into the release?

judfs commented 1 year ago

https://github.com/lcm-proj/lcm/blob/dev-release-1.5/lcm-python/README is dated and features old maintainer email addresses.

Change log things:

Minimum requirement changes: i.e java 6 to 8 ~~ https://github.com/lcm-proj/lcm/commit/2357c6a3a27065f63eca0d7dafc08090e0b28c90 ~~ (edit: actually that commit isn't saying that)

nosracd commented 1 year ago

Good points...

https://github.com/lcm-proj/lcm/blob/dev-release-1.5/lcm-python/README is dated and features old maintainer email addresses.

A lot of that information, in addition to being dated, doesn't seem useful anymore. For example, rather than listing maintainer email addresses it makes more sense to open an issue now that the project is hosted on GitHub. Because of that, 1f019ee00e72db1426ac47f6dc52ba9e5a178b85 just removes the file.

Change log things:

Minimum requirement changes: i.e java 6 to 8 ~~ 2357c6a ~~ (edit: actually that commit isn't saying that)

It's possible that LCM still builds on Java 6 but the oldest version any of our test platforms has packages for is 8 so 1f019ee00e72db1426ac47f6dc52ba9e5a178b85 raises the minimum required version to 8.

tprk77 commented 1 year ago

Sorry I missed that ping before. If possible, I would take a couple days to look the the release.

tprk77 commented 1 year ago

So improvements are great, and it's good to see this work going into LCM. I've found two things I wanted to ask about, and they are both regarding CMake:

Should I go ahead and make these changes?

tprk77 commented 1 year ago

Link: #442, #443