lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

Fix Custom Install Location #428

Closed nosracd closed 1 year ago

nosracd commented 1 year ago

74a323fe8b071171ca4750bb95e34a6b4340bcbf changed PYTHON_SITE from a relative path to an absolute path which breaks custom install locations specified via -DCMAKE_INSTALL_PREFIX when configuring a build directory (DESTDIR and --prefix still seem OK). This happens because install ignores CMAKE_INSTALL_PREFIX if the given install location is an absolute path.

This PR makes it so that PYTHON_SITE should be the same as it was before 74a323fe8b071171ca4750bb95e34a6b4340bcbf. In addition to testing locally, I tested on our CI targets with a series of test commits which refactored the CI to set CMAKE_INSTALL_PREFIX.