search

lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

lcm-python install location in master #432

Closed mrwalter closed 1 year ago

mrwalter commented 1 year ago

Hi,

In the master branch, PYTHON_SITE is set to an absolute path:

https://github.com/lcm-proj/lcm/blob/4f2ef75f4a288109de065dc8fa616c75f73b4c82/lcm-python/CMakeLists.txt#L2):

execute_process(
  COMMAND "${PYTHON_EXECUTABLE}" -c "if True:
    import sysconfig as sc
    print(sc.get_path('platlib'))"
  OUTPUT_VARIABLE PYTHON_SITE
  OUTPUT_STRIP_TRAILING_WHITESPACE)

but I believe that the intended behavior is for this to be a relative path as in the dev-release-1.5:

https://github.com/lcm-proj/lcm/blob/2ab86d351e9861851b3672f80a8ab6f802b1a242/lcm-python/CMakeLists.txt#L2,

execute_process(
  COMMAND "${PYTHON_EXECUTABLE}" -c "if True:
    from sysconfig import get_path
    from os.path import sep
    print(get_path('platlib').replace(get_path('data') + sep, ''))"
  OUTPUT_VARIABLE PYTHON_SITE
  OUTPUT_STRIP_TRAILING_WHITESPACE)
ihilt commented 1 year ago

Closing. See comment in #406.