lcm-logger: Fix -l option

lcm-proj / lcm

Lightweight Communications and Marshalling

GNU Lesser General Public License v2.1

944 stars 385 forks source link

lcm-logger: Fix -l option #465

Closed judfs closed 11 months ago

judfs commented 11 months ago

fix #463

For good measure, I sorted the short optstring and option array as the values need to be clearly unique.

[getopt is a funky api]

judfs commented 11 months ago

hmm...

./format_code.sh --check
FORMATTING OK!

clang-format --version
clang-format version 10.0.0-4ubuntu1

(ubuntu 20.04)

CI seems to disagree

judfs commented 11 months ago

Also: --flush-interval=MS provides the short option -u without calling it out in the help. Not a very descriptive letter. Might be better to remove than to document.

nosracd commented 11 months ago

hmm...

./format_code.sh --check
FORMATTING OK!

clang-format --version
clang-format version 10.0.0-4ubuntu1

(ubuntu 20.04)

CI seems to disagree

Sorry about that. I've attempted to improve the situation in #466. In the meantime, could you try rerunning with clang-format-12 installed as clang-format? Or, feel free to cherry-pick 450a380 if that's easiest.