search

lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

Cmake: Set default build type to release #506

Closed judfs closed 1 month ago

judfs commented 2 months ago

The build instructions simply say cmake .. so I kinda assumed this was already in place.

judfs commented 2 months ago

uh huh.... https://github.com/lcm-proj/lcm/actions/runs/8635337076/job/23672829171?pr=506#step:5:119 no clue

nosracd commented 1 month ago

In the past you've expressed a preference for making changes directly on your PRs, so I added d68c6dd3dcec28e5337291c4ab79585ddc7ea89f to obviate the compiler warnings on the CI's Fedora target.

I think it makes sense for LCM to configure a release build by default. I believe most people tend to use it as a tool rather than debug it. But since a default release build might be unexpected for a lot of users, I also added da0d7f9970baca1c7baa3338476953de0c484fcb to document this behavior as well as give instructions for users to override it.