search

lcm-proj / lcm

Lightweight Communications and Marshalling
GNU Lesser General Public License v2.1
944 stars 385 forks source link

lcm 1.5.0 zip contains "unmappable character for encoding ASCII" #510

Closed pitzor closed 2 months ago

pitzor commented 2 months ago

In the release 1.5.0 zip, at least 2 files contains unmappable characters: lcm/spy/Spy.java:41: error: unmappable character for encoding ASCII String spacer = " ??? "; ^ lcm/logging/LogPlayer.java:1123: error: unmappable character for encoding ASCII String spacer = " ??? "; ^ When I check the files using vim (ubuntu 22) or TextEdit (MacOS 14) I can see that the actual character is a special character not included in ASCII.

The line actually looks like this: String spacer = " • ";

This problem can be seen in the repository, tag 1.5.0, as well but it is not present in master. The exact same file is actually handling this character as a unicode character, like this: String spacer = " \u2022 ";

Using ubuntu 22 and jdk 18 this worked to build with no errors Using ubuntu 20 and idk 11 had the above issues

Maybe good to create 1.5.1 zip

nosracd commented 2 months ago

Closing as a duplicate of #454, but feel free to reopen if you believe this is in error.

One workaround for 1.5.0 in setting the locale (f96c9c30e5745743e1b9594c5a039561d0e1d4ba removes that workaround from the Fedora dockerfile when it was no longer neccessary). Of course, as you've noted the issue is resolved on the latest version of the master branch so you could also use that.