Bug: zmath.h:38:11: fatal error: version.h: No such file or directory

[jubalh]

Describe the bug I use the tarball from: http://www.isthe.com/chongo/src/calc/calc-2.15.0.0.tar.bz2 With the following build file. And get:

...
[    8s] longbits.h formed
[    8s] rm -f errcode
[    8s] gcc -DCALC_SRC -DCUSTOM -Wall -Wextra -pedantic   -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -g -fno-strict-aliasing -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -I/usr/include/ncursesw  -UUNBAN -fPIC   -DERRCODE_SRC errtbl.c -o errcode
[    8s] In file included from qmath.h:32,
[    8s]                  from cmath.h:32,
[    8s]                  from value.h:33,
[    8s]                  from calc.h:33,
[    8s]                  from func.h:32,
[    8s]                  from errtbl.c:50:
[    8s] zmath.h:38:11: fatal error: version.h: No such file or directory
[    8s]    38 | # include "version.h"
[    8s]       |           ^~~~~~~~~~~
[    8s] compilation terminated.

Full build log can be found here.

2.14.3.5 built fine. This only happens with 2.15.0.0.

I do not find the version.h in the tree. Is there something I need to run to generate this from version.c first? Maybe I'm missing this in the build file.

[lcn2]

It appears that version.h was omitted on the build manifest.

Sorry (tm Canada 🇨🇦): expect an emergency update for calc version 2.15.0.1 later this evening Pacific time.

[lcn2]

We have discovered the reason why version.h was missed in the manifest. We are currenrly working on a test so that we can better catch condition where a missing file is detected during the build process.

[lcn2]

We have deleted the release and will be shipping a version 2.15.0.1 soon.

[jubalh]

Deleting releases is usually not a good thing. Distros can already have referenced or used this. I think generally it's better to just leave it there and then publish 2.15.0.1 when it's ready. A note could be added in 2.15.0.0. But I would suggest to not remove releases in the future.

[lcn2]

With commit e96ef61718e5e13f3cd256e719cdc061017d9ba6 we believe we have addressed the missing version.h file AND we have put into place, a tool that will help avoid future problems such as a missing distribution file.

We are testing the code now.

[lcn2]

With commit b54f68a797491be91f8671ae69c3291aeec74e09 we have addressed this problem AND put into place checks to avoid a similar mistake in the future.

Thank you for your bug report, @jubalh!

We have pulled calc version 2.15.0.0 and are now in the process of releasing calc version 2.15.0.1.

[pmetzger]

@lcn2 BTW, thanks for all your work maintaining Calc. It's a wonderful little tool, and I use it all day every day.

[lcn2]

@lcn2 BTW, thanks for all your work maintaining Calc. It's a wonderful little tool, and I use it all day every day.

You are most welcome 🙏 and thank you for your kind words: glad it is useful!

With release of calc version 2.15.0.1 this issue has been resolved.

[jubalh]

With release of calc version 2.15.0.1 this issue has been resolved.

Confirmed! Thanks!

[pmetzger]

MacPorts has now been updated to 2.15.0.1.