lcnetdev / bibframe2marc

XSLT application to generate MARCXML from BIBFRAME RDF/XML
Creative Commons Zero v1.0 Universal
16 stars 5 forks source link

empty MARC fields with geographic subdivision URIs #22

Open jodiw01 opened 4 months ago

jodiw01 commented 4 months ago

When a MARC record contains a geographic heading that has a subdivision heading -- and has two URIs in id.loc.gov -- bibframe2marc is selecting the subdivision URI and creating an empty MARC field. An added complication is that the geographic heading is used as a bf:PrimaryContribution in the following examples.

Examples: 001 10277584 https://id.loc.gov/resources/works/10277584.html 2\$aAlaska$1http://id.loc.gov/rwo/agents/n79018447-781$4http://id.loc.gov/vocabulary/relators/ctb

Correct heading: 110 2\$aAlaska$1http://id.loc.gov/rwo/agents/n79018447$4http://id.loc.gov/vocabulary/relators/ctb

001 10053631 https://id.loc.gov/resources/works/10053631.html 2\$aSweden$1http://id.loc.gov/rwo/agents/n79021184-781$4http://id.loc.gov/vocabulary/relators/ctb

Correct heading: 110 2\$aSweden$1http://id.loc.gov/rwo/agents/n79021184$4http://id.loc.gov/vocabulary/relators/ctb

001 21289967 https://id.loc.gov/resources/works/21289967.html 2\$aPanama$1http://id.loc.gov/rwo/agents/n79068688-781$4http://id.loc.gov/vocabulary/relators/ctb

Original MARC: 1101 $aPanama.

001 7250281 https://id.loc.gov/resources/works/7250281.html 2\$aAustria$1http://id.loc.gov/rwo/agents/n79040121-781$4http://id.loc.gov/vocabulary/relators/ctb

Original MARC: 1101 $aAustria.$kLaws, statutes, etc.

kefo commented 4 months ago

This is has two source issues.

1) An LC system issue. 2) A MARC-to-BF conversion issue.

With respect to '2,' I've not looked at the specs, but assuming I grabbed the correct passage of code (I was working quickly with an eye to capturing this information versus descending the rabbit hole to its ultimate depth), the $k is not being converted:

https://github.com/lcnetdev/marc2bibframe2/blob/master/xsl/ConvSpec-1XX%2C7XX%2C8XX-names.xsl#L772-L778

jodiw01 commented 4 months ago

The lack of a $k is not a factor for the Alaska example, but it is for the Sweden example. (but $k doesn't seem appropriate for a treaty name?)