search

lcnetdev / marc2bibframe2

Convert MARC records to BIBFRAME2 RDF
http://www.loc.gov/bibframe/
Creative Commons Zero v1.0 Universal
88 stars 35 forks source link

Conversion error with 240 and 880 fields #49

Closed osma closed 7 years ago

osma commented 7 years ago

I tried to convert this record and got this error:

runtime error: file ../marc2bibframe2/xsl/ConvSpec-240andX30-UnifTitle.xsl line 415 element attribute
xsl:attribute: Cannot add attributes to an element if children have been already added to the element.

The error seems to be related to the 240 field (which contains a transliterated original title) and the 880 field, which contains the original Cyrillic title.

According to our catalogers the record is using 240 and 880 fields correctly, so it seems like a bug in the converter.

osma commented 7 years ago

I'm using v1.2.0

wafschneider commented 7 years ago

The issue was an attempt to create an xml:lang attribute at the wrong point in the template. Pull request #50 in progress. @kirkhess -- I will also make release 1.2.2, so the fix can be included in the update to lx2.loc.gov next week.

osma commented 7 years ago

Thanks again @wafschneider !