search

lcnetdev / marc2bibframe2

Convert MARC records to BIBFRAME2 RDF
http://www.loc.gov/bibframe/
Creative Commons Zero v1.0 Universal
88 stars 35 forks source link

Don't create bflc:relatorMatchKey property #81

Closed wafschneider closed 5 years ago

wafschneider commented 6 years ago

This property was created to work around issues with the LC label lookup service and trailing punctuation, it is no longer needed.

wafschneider commented 5 years ago

This will also require some tweaking of the sample yaz record conversion configuration.

wafschneider commented 5 years ago

In my testing, the label service for relators still fails if there is trailing punctuation:

http://id.loc.gov/vocabulary/relators/label/illustrator -- results in "302 FOUND" with header Location : http://id.loc.gov/vocabulary/relators/ill

http://id.loc.gov/vocabulary/relators/label/illustrator. -- results in "404 Not Found"

@ntra00 -- am I missing something?

ntra00 commented 5 years ago

I think we’ve been adding the chop-punctuation on a piecemeal basis to our label service. Maybe we should just add it more broadly to any label lookups. We’ll discuss internally and address this. We definitely would need to have it for any lookups we put into the record-conv.xml file.

ntra00 commented 5 years ago

wayne, the label service covers relators (now). http://id.loc.gov/vocabulary/relators/label/illustrator.