lcnetdev / marc2bibframe2

Convert MARC records to BIBFRAME2 RDF
http://www.loc.gov/bibframe/
Creative Commons Zero v1.0 Universal
88 stars 35 forks source link

880/33X conversion #93

Closed wafschneider closed 5 years ago

wafschneider commented 5 years ago

@ntra00 reports: Wayne, based on how the 336, 337 and 338 work in conversion3xx, I think the 880 calls to those functions are missing the parameter “pUriStem”.

Here’s an example where the media/media is just getting a uri of “n”:

http://id.loc.gov/tools/bibframe/compare-id/full-rdf?find=20718085

3xx:

<xsl:template match="marc:datafield[@tag='337']" mode="instance">

    <xsl:param name="serialization" select="'rdfxml'"/>

    <xsl:apply-templates select="." mode="rdaResource">

      <xsl:with-param name="serialization" select="$serialization"/>

      <xsl:with-param name="pProp">bf:media</xsl:with-param>

      <xsl:with-param name="pResource">bf:Media</xsl:with-param>

      <xsl:with-param name="pUriStem"><xsl:value-of select="$mediaType"/></xsl:with-param>

    </xsl:apply-templates>

  </xsl:template>

can you check ? here’ s the 880 code:

<xsl:when test="$tag='337'">

        <xsl:apply-templates select="." mode="rdaResource">

          <xsl:with-param name="serialization" select="$serialization"/>

          <xsl:with-param name="pProp">bf:media</xsl:with-param>

          <xsl:with-param name="pResource">bf:Media</xsl:with-param>

        </xsl:apply-templates>

      </xsl:when>
wafschneider commented 5 years ago

Issue is resolved in v1.4.0 branch.