lcnetdev / scriptshifter

Creative Commons Zero v1.0 Universal
11 stars 5 forks source link

Bibframe.org issue #120

Closed quinnka2 closed 1 month ago

quinnka2 commented 1 month ago

I don't know if this is the best place to report these issues. But when using Scriptshifter in bibframe.org, we found these when using Roman to script:

scossu commented 1 month ago

@thisismattmiller I have no insight in these errors, but the latest PR (still unmerged) should surface back end errors more transparently.

scossu commented 1 month ago

@quinnka2 for the Russian and Ukrainian errors, can you provide some sample strings with the expected outputs?

scossu commented 1 month ago

@quinnka2 for the second issue, please try again in test. See #121 .

quinnka2 commented 1 month ago

@scossu I responded on #121. But here are the sample strings.

Original: Здравствуйте, меня зовут Келли

Transliterated script to Roman to: Zdravstvuĭte, meni︠a︡ zovut Kelli.

Zdravstvuĭte, meni︠a︡ zovut Kelli.

Transliterated Roman to script to: Здравствуйте, еня овут елли. Missing the м, з, and К.

scossu commented 1 month ago

Are you using the test site (https://scriptshifter-test.knowledgetx.com/?lang=russian)? I cannot reproduce your error. the fix may have not been pushed to production if you are testing there.

quinnka2 commented 1 month ago

Yes, I was testing in production. It looks fixed in test.

And in test, the message I get for the first issue, the SyntaxError: Unexpected token error, I see:

WARNING: ScriptShifter API replied with status code 400: Roman-to-script transliteration not yet supported for arabic. Please review your input before repeating this request.

That is more informative. Thanks!