lcodeca / SUMOActivityGen

An Activity-based Multi-modal Mobility Scenario Generator for SUMO. This project is available in the Eclipse SUMO contributed tools section (https://github.com/eclipse/sumo/tree/master/tools/contributed) under the name SAGA (SUMO Activity GenerAtion).
Eclipse Public License 2.0
40 stars 25 forks source link

Fix vehicle stopping lane search for on-demand vehicles #13

Closed RoobinGood closed 4 years ago

RoobinGood commented 4 years ago

For trips with vtype = 'on-demand' function _get_stopping_lane fails cause there is no such type.

I suppose it should be a taxi so I just patched argument for lane.allows call and didn't touch another activitygen logic.

lcodeca commented 4 years ago

The “on-demand” type is defined in the default vType file (https://github.com/lcodeca/SUMOActivityGen/blob/taxi-fleet/defaults/basic.vType.xml#L10). This comes from before the new features for taxies, and it was meant to angle different kind of on-demand vehicles. Given that there is a new ongoing branch that works on the taxi-fleet (https://github.com/lcodeca/SUMOActivityGen/tree/taxi-fleet) I’m not going to merge to the master taxi-related improvements until that new branch is stable.

Note: if the master version of SAGA crashes, please open an issues with the files, details, and error.

RoobinGood commented 4 years ago

Ok, thanks for explanations.

Closed.