lcolladotor / biocthis

Automate package and project setup for Bioconductor packages
https://lcolladotor.github.io/biocthis/
50 stars 17 forks source link

Split up install dependencies pass 1 and 2 #18

Closed grst closed 3 years ago

grst commented 3 years ago

If one of the packages fails being installed during pass 1, R exits with an status != 0, causing the entire workflow to halt.

As errors may happen during this step, I suggest to split up pass 1 and 2, explicitly allowing errors in pass 1 using continue-on-error: true.

lcolladotor commented 3 years ago

Hi,

I just noticed your PR. Hm... do you have an actions log report I can check to see the situation your PR describes?

Thanks!

grst commented 3 years ago

unfortunately not... the PR of question (https://github.com/Accio/BioQC/pull/23) got squashed&merged and therefore purged all CI logs.

lcolladotor commented 3 years ago

Ok. I'll merge the PR since I don't think that it can hurt =) Thanks for the PR ^^.