Question: BIOCVERSIONNUM environment variable?

lcolladotor / biocthis

Automate package and project setup for Bioconductor packages

https://lcolladotor.github.io/biocthis/

50 stars 17 forks source link

Question: BIOCVERSIONNUM environment variable? #2

Closed sa-lee closed 4 years ago

sa-lee commented 4 years ago

Hi Leo,

Thanks for this package, I just set up GHA for plyranges and everything seems to work pretty seamlessly!

I was curious how the environment variable gets set for the windows and macos. On a current PR the jobs seems to be unable to install Bioc because the environment variable is empty.

Context

Provide some context for your bug report or feature request. This could be the:

link to windows GHA where the step fails: https://github.com/sa-lee/plyranges/runs/690010956?check_suite_focus=true

Any ideas why this didn't work?

sa-lee commented 4 years ago

I think I've worked this out now! But thanks again for this package setting up the actions was very straightforward thanks to biocthis!

Takkoona commented 4 years ago

Same problem here and I think I've found the cause. When setting up the versions info, it's assumed the branch name in $GITHUB_REF to have either 'master' or 'RELEASE_' otherwise biocversion will be empty string. So its dependent variables biocversionnum and rversion become empty string. I'll try solving this and make a pull request if possible.

Takkoona commented 4 years ago

Here is how I solve the issue. But this only applies when it's merged to the master branch while it could very well be one of the release branches. The solution is not generic enough so I hesitate to make a pull request.

lcolladotor commented 4 years ago

This will hopefully be clearer thanks to https://github.com/lcolladotor/biocthis/pull/11 by Marcel Ramos