search

lcolladotor / biocthis

Automate package and project setup for Bioconductor packages
https://lcolladotor.github.io/biocthis/
50 stars 17 forks source link

[BUG] RELEASE branch variable should still be upper case #3

Closed sa-lee closed 4 years ago

sa-lee commented 4 years ago

On the actions yml file, I think the variable that's set for the biocversion should still be upper case (or converted to upper case so the correct docker instance can be pulled.

Context

Provide some context for your bug report or feature request.

I'm moving a bunch of my packages to use your workflow file, and it errored on my release branch here:

https://github.com/sa-lee/fluentGenomics/runs/698333750?check_suite_focus=true#step:2:12

lcolladotor commented 4 years ago

Thanks for the info! I'll add this soon =)

lcolladotor commented 4 years ago

@Takkoona solved this at https://github.com/lcolladotor/biocthis/pull/4 ^^