search

lcompilers / lpython

Python compiler
https://lpython.org/
Other
1.5k stars 157 forks source link

Fix isspace edge case #2489

Closed advikkabra closed 6 months ago

advikkabra commented 7 months ago

An empty string should return False when the isspace method is called.

advikkabra commented 7 months ago

Added the test, and also noticed a bug in the C++ implementation, so fixed the same.

anutosh491 commented 6 months ago

also noticed a bug in the C++ implementation

Ohh what's this ? Have you tested it out ? Remember to raise a separate PR for every other issue you are fixing. Helps us review and keep track of the change. Nothing wrong with atomic/small commits :)

advikkabra commented 6 months ago

It is the same edge case, just for constant empty strings as well. I will write a test for it as well.