search

lcompilers / lpython

Python compiler
https://lpython.org/
Other
1.5k stars 157 forks source link

Punctuation error and word-usage error in LPython error message #2493

Open rebcabin opened 7 months ago

rebcabin commented 7 months ago 
(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables which can be reduced to compile time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^

"compile time" must be hyphenated: "compile-time" (reference: Grammarly.com plugin or Gregg Reference Manual, any edition, chapter 8).

(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables which can be reduced to compile-time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^

also, "which can" must be "that can" in American English (reference: Grammarly.com plugin)

(lp) ┌─(~/Documents/GitHub/lpython/integration_tests)────(brian@MacBook-Pro:s001)─┐
└─(12:16:55 on vector-backend ✹ ✭)──> lpython ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py                                              2 ↵ ──(Tue,Feb06)─┘
semantic error: Only those local variables that can be reduced to compile-time constant should be used in dimensions of an array.
  --> ../ISSUES/UNHANDLED-EXCEPTIONS/Issue2492.py:18:15
   |
18 |     A_nm: i16[n, m] = empty((n, m), dtype=int16)
   |               ^
rebcabin commented 7 months ago

Another one (Grammarly missed this!)

"constant" should be plural "constants"

Only those local variables that can be reduced to compile-time constants should be used in dimensions of an array.
rudhrabehara commented 7 months ago

worked on it and opened a PR

rudhrabehara commented 7 months ago

please review and give suggestions

kmr-srbh commented 5 months ago

@Shaikh-Ubaid This issue can be closed with reference to the above merged PR.