search

lcompilers / lpython

Python compiler
https://lpython.org/
Other
1.51k stars 164 forks source link

Jupyter Kernel #2764

Closed Vipul-Cariappa closed 4 months ago

Vipul-Cariappa commented 4 months ago

2756

Vipul-Cariappa commented 4 months ago

@certik, I have squash merged the changes make in #2762 and cherry-picked the necessery changes from #2756.

certik commented 4 months ago

Looks like there is some issue with the bit_length implementation (https://github.com/lcompilers/lpython/issues/1836), so it's fine to disable the test. The other macOS interactive issue was fixed. I don't understand exactly the problem, but it looks like something with signed/unsigned. The change in this PR works on all platforms, so it gets us unblocked.

Let's merge it, and we can fix the rest of the issues later.

certik commented 4 months ago

I am merged this as is, since all tests pass. Now I'll submit a PR to fix the package versions: